Add Ubuntu 24.04 support for feedsim on ARM aarch64 (G5)#431
Open
ahmadelyoussef wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Add Ubuntu 24.04 support for feedsim on ARM aarch64 (G5)#431ahmadelyoussef wants to merge 1 commit intofacebookresearch:v2-betafrom
ahmadelyoussef wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
Summary: This change adds support for installing feedsim on Ubuntu 24.04 running on ARM aarch64 (G5) systems. Key changes: - Updated `install_feedsim_aarch64_ubuntu.sh` to use system Boost libraries (`libboost-all-dev`) instead of building from source, avoiding ABI mismatch issues that occur with source-built Boost on Ubuntu 24.04 - Added Ubuntu 24.04 detection to the compatibility patches section (alongside existing Ubuntu 22.04 support) for folly and rsocket-cpp - Updated CMake build files (build-fbthrift.cmake, build-fizz.cmake, build-mvfst.cmake, build-wangle.cmake) to properly pass through Boost configuration variables (`BOOST_ROOT`, `Boost_INCLUDE_DIR`, `Boost_NO_BOOST_CMAKE`) to ensure consistent Boost usage across all third-party dependencies These changes enable feedsim benchmarking on the newer Ubuntu 24.04 OS with ARM aarch64 architecture, which is required for G5 hardware enablement. Differential Revision: D92219539
meta-cla
bot
added
the
CLA Signed
|
@ahmadelyoussef has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92219539. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds support for installing feedsim on Ubuntu 24.04 running on ARM aarch64 (G5) systems.
Key changes:
install_feedsim_aarch64_ubuntu.shto use system Boost libraries (libboost-all-dev) instead of building from source, avoiding ABI mismatch issues that occur with source-built Boost on Ubuntu 24.04BOOST_ROOT,Boost_INCLUDE_DIR,Boost_NO_BOOST_CMAKE) to ensure consistent Boost usage across all third-party dependenciesThese changes enable feedsim benchmarking on the newer Ubuntu 24.04 OS with ARM aarch64 architecture, which is required for G5 hardware enablement.
Differential Revision: D92219539