refactor(encoding): Consolidate encodingFactory_ into EncodingTrait#617
Open
HuamengJiang wants to merge 1 commit intofacebookincubator:mainfrom
Open
refactor(encoding): Consolidate encodingFactory_ into EncodingTrait#617HuamengJiang wants to merge 1 commit intofacebookincubator:mainfrom
HuamengJiang wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: Consolidate the `encodingFactory_` callable and `getStringBuffersFromDecoder_` bool pair with trait-based branching using `DefaultEncodingTrait::decode` and `LegacyEncodingTrait::decode`. Since `encodingFactory_` was always determined by `getStringBuffersFromDecoder_`, the factory is redundant — the trait already captures the legacy vs non-legacy distinction. This makes the branching of encoding depend solely on `getStringBuffersFromDecoder_` Differential Revision: D97603426
meta-cla
bot
added
the
CLA Signed
|
@HuamengJiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97603426. |
xiaoxmeng
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Consolidate the
encodingFactory_callable andgetStringBuffersFromDecoder_bool pairwith trait-based branching using
DefaultEncodingTrait::decodeandLegacyEncodingTrait::decode. SinceencodingFactory_was always determined bygetStringBuffersFromDecoder_, the factory is redundant — the trait already capturesthe legacy vs non-legacy distinction.
This makes the branching of encoding depend solely on
getStringBuffersFromDecoder_Differential Revision: D97603426