This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Bugfix/max packet byte size#145
Open
ryanNealOpaque wants to merge 7 commits intofacebookarchive:masterfrom
Open
Bugfix/max packet byte size#145ryanNealOpaque wants to merge 7 commits intofacebookarchive:masterfrom
ryanNealOpaque wants to merge 7 commits intofacebookarchive:masterfrom
Conversation
…1501 bytes which can cause massive network latency with certain routers
|
Hi @ryanNealOpaque! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
jgbt
force-pushed
the
bugfix/MaxPacketByteSize
branch
from
ac86c1d to
1491ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when sending a fragmented packet as reliable_sequenced the math for the header size is one byte off.