Skip to content

[eslint-plugin] Add grid shorthand expansion to stylex-valid-shorthands#1477

Merged
abhakat merged 1 commit intomainfrom
grid-auto-fix
Mar 16, 2026
Merged

[eslint-plugin] Add grid shorthand expansion to stylex-valid-shorthands#1477
abhakat merged 1 commit intomainfrom
grid-auto-fix

Conversation

@abhakat
Copy link
Copy Markdown
Contributor

@abhakat abhakat commented Feb 9, 2026

Expand grid-area, grid-row, grid-column, and grid-template shorthands into their longhand equivalents with spec-conformant autofix. The grid-area expansion correctly applies the CSS omission rule per-axis, only copying end values from start values for custom-ident groups.

What changed / motivation ?

Want to create the auto-fix to auto-fix future issues.

Linked PR/Issues

Fixes #1476

Additional Context

Added some tests to show/validate behavior

Pre-flight checklist

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
stylex Skipped Skipped Mar 16, 2026 10:03am

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.
yarn workspace v1.22.22
yarn run v1.22.22
$ node ./compare.js /tmp/tmp.vZ1m0dEH5m /tmp/tmp.GLp8gWRmNM

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 561 554 0.99 -
· complex create 68 68 1.00
babel-plugin: stylex.createTheme
· basic themes 425 428 1.01 +
· complex themes 35 35 1.00
Done in 0.07s.
Done in 0.29s.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
yarn workspace v1.22.22
yarn run v1.22.22
$ node ./compare.js /tmp/tmp.62WWz3SiJT /tmp/tmp.euTnilQJTp

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,331 1,331 1.00
· minified 4,209 4,209 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,793 1,793 1.00
· minified 4,915 4,915 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,653 99,867 1.00 +
· minified 747,850 747,613 1.00 -
Done in 0.09s.
Done in 0.33s.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2026
Expand grid-area, grid-row, grid-column, and grid-template shorthands
into their longhand equivalents with spec-conformant autofix. The
grid-area expansion correctly applies the CSS omission rule per-axis,
only copying end values from start values for custom-ident groups.
@abhakat abhakat merged commit 679eae0 into main Mar 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[eslint-plugin] Add grid shorthand expansion to stylex-valid-shorthands

2 participants