Improve @throwOnFieldError error on mutations to suggest @catch#5203
Open
captbaritone wants to merge 2 commits intofacebook:mainfrom
Open
Improve @throwOnFieldError error on mutations to suggest @catch#5203captbaritone wants to merge 2 commits intofacebook:mainfrom
captbaritone wants to merge 2 commits intofacebook:mainfrom
Conversation
…ESULT) Previously, using @throwOnFieldError on a mutation produced a generic "not supported in this location" error. This updates the error to specifically recommend using @catch(to: RESULT) instead, which is the supported alternative for mutations.
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D95583355. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@throwOnFieldErrorto a mutation, they now get a helpful error recommending@catch(to: RESULT)instead of the generic "not supported in this location" message.disallow_readtime_features_in_mutationsvalidation pass, alongside similar mutation-specific checks for@requiredand resolvers.Test plan
mutation_with_throw_on_field_error.invalidin thedisallow_readtime_features_in_mutationstest suitecargo test -p relay-transforms --test graphql_disallowreadtime_features_in_mutations_testandcargo test -p relay-codegen --test relay_codegen_throw_on_field_error_directive_codegen_test