Skip to content

Fix FB_WWW eprh bundle dev guard#36238

Merged
jackpope merged 1 commit intofacebook:mainfrom
jackpope:compiler-feature-flags-2
Apr 8, 2026
Merged

Fix FB_WWW eprh bundle dev guard#36238
jackpope merged 1 commit intofacebook:mainfrom
jackpope:compiler-feature-flags-2

Conversation

@jackpope
Copy link
Copy Markdown
Contributor

@jackpope jackpope commented Apr 8, 2026

We use FB_WWW bundle to inject internal feature flag values, but need to use NODE guard type because this is a node script -- DEV is breaking internal builds

Follow up to #35951

We use FB_WWW bundle to inject internal feature flag values, but need
to use NODE guard type because this is a node script -- __DEV__ is breaking
internal builds
@meta-cla meta-cla bot added the CLA Signed label Apr 8, 2026
@jackpope jackpope requested a review from EugeneChoi4 April 8, 2026 20:06
@react-sizebot
Copy link
Copy Markdown

Comparing: 404b38c...0b41820

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 612.91 kB 612.91 kB = 108.30 kB 108.31 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.89 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 678.85 kB 678.85 kB = 119.27 kB 119.27 kB
facebook-www/ReactDOM-prod.classic.js = 698.24 kB 698.24 kB = 122.65 kB 122.65 kB
facebook-www/ReactDOM-prod.modern.js = 688.55 kB 688.55 kB = 121.03 kB 121.03 kB
facebook-www/ESLintPluginReactHooks-prod.classic.js Deleted 2,038.95 kB 0.00 kB Deleted 297.58 kB 0.00 kB
facebook-www/ESLintPluginReactHooks-prod.modern.js Deleted 2,038.95 kB 0.00 kB Deleted 297.58 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ESLintPluginReactHooks-prod.classic.js Deleted 2,038.95 kB 0.00 kB Deleted 297.58 kB 0.00 kB
facebook-www/ESLintPluginReactHooks-prod.modern.js Deleted 2,038.95 kB 0.00 kB Deleted 297.58 kB 0.00 kB

Generated by 🚫 dangerJS against 0b41820

@jackpope jackpope merged commit 733d3aa into facebook:main Apr 8, 2026
241 of 242 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2026
We use FB_WWW bundle to inject internal feature flag values, but need to
use NODE guard type because this is a node script -- __DEV__ is breaking
internal builds

Follow up to #35951

DiffTrain build for [733d3aa](733d3aa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants