fix: pin 10 unpinned action(s),extract 6 unsafe expression(s) to env vars#36144
fix: pin 10 unpinned action(s),extract 6 unsafe expression(s) to env vars#36144dagecko wants to merge 1 commit intofacebook:mainfrom
Conversation
…vars Automated security fixes applied by Runner Guard (https://github.com/Vigilant-LLC/runner-guard). Changes: .github/workflows/compiler_discord_notify.yml | 2 +- .github/workflows/compiler_prereleases_manual.yml | 2 +- .github/workflows/compiler_prereleases_nightly.yml | 2 +- .github/workflows/devtools_discord_notify.yml | 2 +- .github/workflows/devtools_regression_tests.yml | 4 +++- .github/workflows/runtime_build_and_test.yml | 12 +++++++++--- .github/workflows/runtime_commit_artifacts.yml | 4 +++- .github/workflows/runtime_discord_notify.yml | 2 +- .github/workflows/runtime_prereleases.yml | 4 +++- .github/workflows/runtime_prereleases_manual.yml | 4 ++-- .github/workflows/runtime_prereleases_nightly.yml | 4 ++-- .github/workflows/shared_label_core_team_prs.yml | 2 +- 12 files changed, 28 insertions(+), 16 deletions(-)
|
Hi @dagecko! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Fix: CI/CD Security Vulnerabilities in GitHub Actions
Hi! Runner Guard, an open-source
CI/CD security scanner by Vigilant Cyber Security,
identified security vulnerabilities in this repository's GitHub Actions workflows.
This PR applies automated fixes where possible and reports additional findings
for your review.
Fixes applied (in this PR)
.github/workflows/compiler_discord_notify.yml.github/workflows/compiler_prereleases_manual.yml.github/workflows/compiler_prereleases_nightly.yml.github/workflows/devtools_discord_notify.yml.github/workflows/devtools_regression_tests.yml.github/workflows/runtime_build_and_test.yml.github/workflows/runtime_commit_artifacts.yml.github/workflows/runtime_discord_notify.yml.github/workflows/runtime_prereleases.yml.github/workflows/runtime_prereleases_manual.yml.github/workflows/runtime_prereleases_nightly.yml.github/workflows/shared_label_core_team_prs.ymlAdvisory: additional findings (manual review recommended)
| Rule | Severity | File | Description |
| RGS-005 | medium |
.github/workflows/shared_label_core_team_prs.yml| Excessive Permissions on Untrusted Trigger |Why this matters
GitHub Actions workflows that use untrusted input in
run:blocks, exposesecrets inline, or use unpinned third-party actions are vulnerable to
code injection, credential theft, and supply chain attacks. These are the same
vulnerability classes exploited in the tj-actions/changed-files incident
and subsequent supply chain attacks, which compromised CI secrets across
thousands of repositories.
How to verify
Review the diff — each change is mechanical and preserves workflow behavior:
${{ }}expressions fromrun:blocks intoenv:mappings, preventing shell injection(original version tag preserved as comment)
ACTIONS_RUNNER_DEBUG/ACTIONS_STEP_DEBUGwhich leak secrets in workflow logs
Run
brew install Vigilant-LLC/tap/runner-guard && runner-guard scan .or install from therepo to verify.
Found by Runner Guard | Built by Vigilant Cyber Security | Learn more
If this PR is not welcome, just close it -- we won't send another.