eslint-plugin-react-hooks: allow ref-guarded setState in effects#35803
eslint-plugin-react-hooks: allow ref-guarded setState in effects#35803saurabhchopade wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @saurabhchopade! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
josephsavona
left a comment
There was a problem hiding this comment.
We intend to ship this on by default, rather than have different settings in different modes.
Summary
Fixes #34858.
Makes enableAllowSetStateFromRefsInEffects explicit in ESLint compiler runtime options so behavior does not depend on compiler default values.
Adds regression tests for ref-guarded first-render setState in set-state-in-effect rule.
Changes
Testing
Attempted local run of:
pm run test -- packages/eslint-plugin-react-hooks/tests/ReactCompilerRuleTypescript-test.ts