Skip to content

bug-fix: DevTools - Error logic for missing nodes while deletion #35716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
11Warrior wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −8
Open

bug-fix: DevTools - Error logic for missing nodes while deletion #35716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
336097d
bug-fix: DevTools - Error logic for missing nodes while deletion
11Warrior Feb 7, 2026
207e4d5
Improve node removal logic in store.js
11Warrior Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/react-devtools-shared/src/devtools/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,17 +1572,18 @@ export default class Store extends EventEmitter<{
const id = operations[i];
const element = this._idToElement.get(id);

i += 1;
if (element === undefined) {
this._throwAndEmitError(
Error(
`Cannot remove node "${id}" because no matching node was found in the Store.`,
),
);

break;
/*
- there may be further nodes in the batch to be processed hence throwing error right now is not a good soln
- Our store may be partially updated because of this logic
- So I changed it to look for further nodes and skip removing this node
- logically as it is absent so its better logically
*/
continue;
}

i += 1;


const {children, ownerID, parentID, weight} = element;
if (children.length > 0) {
Expand Down