fix: Register HeadlessJsTaskSupportModule in CoreReactPackage#56266
Open
taibin wants to merge 5 commits intofacebook:mainfrom
Open
fix: Register HeadlessJsTaskSupportModule in CoreReactPackage#56266taibin wants to merge 5 commits intofacebook:mainfrom
taibin wants to merge 5 commits intofacebook:mainfrom
Conversation
The resolve() method in BorderColors had incorrect fallback priority order. Physical edge colors (BOTTOM, TOP, LEFT, RIGHT) should have higher priority than logical block colors (BLOCK_START, BLOCK_END, BLOCK) and shorthand colors. This ensures setting borderBottomColor properly overrides borderBlockColor. Fixes facebook#38335
…apping The registerNatives() function incorrectly mapped the JNI 'disable' method to HermesSamplingProfiler::enable instead of HermesSamplingProfiler::disable, which corrupted the sampling profiler state when calling HermesSamplingProfiler.disable() from Java. Fixes facebook#56126
[Android] [Fixed] - Fix HermesSamplingProfiler JNI 'disable' method mapping
…tyServices APIs Add new AccessibilityInfo APIs to query installed and enabled accessibility services on Android. - `getInstalledAccessibilityServices()`: Returns list of all installed accessibility services - `getEnabledAccessibilityServices()`: Returns list of currently enabled accessibility services Each service object contains: - `id`: The unique identifier of the accessibility service - `name`: The human-readable name of the service This allows developers to tailor their app's UI based on specific accessibility services the user has installed or enabled. Closes facebook#30864 Closes facebook#30862 [ANDROID] [ADDED] - Added getInstalledAccessibilityServices and getEnabledAccessibilityServices APIs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The HeadlessJsTaskSupportModule was not included in any ReactPackage, causing AppRegistry.notifyTaskFinished() to fail silently. This meant headless JS tasks would not properly signal completion to the calling service, leaving it to linger unnecessarily. This fix adds HeadlessJsTaskSupportModule to CoreReactPackage so that notifyTaskFinished and notifyTaskRetry methods are properly available. Fixes facebook#56263 [ANDROID] [FIXED] - Register HeadlessJsTaskSupportModule in CoreReactPackage Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
meta-cla
bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
facebook-github-tools
bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
HeadlessJsTaskSupportModulewas not included in any ReactPackage, causingAppRegistry.notifyTaskFinished()to fail silently. This meant headless JS tasks would not properly signal completion to the calling service, leaving it to linger unnecessarily.This fix adds
HeadlessJsTaskSupportModuletoCoreReactPackageso thatnotifyTaskFinishedandnotifyTaskRetrymethods are properly available.Changes
HeadlessJsTaskSupportModuleimport@ReactModuleListannotationgetModule()methodTest Plan
notifyTaskFinished()Changelog
[ANDROID] [FIXED] - Register HeadlessJsTaskSupportModule in CoreReactPackage
Fixes #56263
🤖 Generated with Claude Code