Update the FlatList Component in Lists#29222
Closed
ayushjainrksh wants to merge 1 commit intofacebook:mainfrom
Closed
Update the FlatList Component in Lists#29222ayushjainrksh wants to merge 1 commit intofacebook:mainfrom
ayushjainrksh wants to merge 1 commit intofacebook:mainfrom
Conversation
Base commit: b2570bd |
Base commit: 0f24b1b |
cacbc0e to
d4a2836
Compare
* Update the title, prop descriptions and method descriptions from docs. * Add SnackPlayer examples. * Remove unnecessary asterisks in comments. * Wrap comments to 80 characters * Add description to method FlowTypes * Add prop types with type annotation
d4a2836 to
f5577ba
Compare
Contributor
|
Thanks for this contribution, @ayushjainrksh, and apologies for not getting around to it until now. This MLH-Fellowship project is not currently being worked on so we're going to close this PR to focus on active ones. If you feel this is an error or if you'd like to pick this up again, please let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MLH-Fellowship#32
Summary
The PR is part of an effort to update the code comments to match the current documentation on the React Native website. The project is a part of MLH fellowship program and involves automatic generation of the website docs from code comments and flow types as the end result.
To learn more about the project you can visit the project wiki:
Link to the documentation(the source of truth):
Changes
*in comments.Changelog
[Internal]
Test Plan
All changes are made to the code comments and thus there is no need for testing.
Reviewed by @jevakallio