Dedupe the --module override rewriting in pyrefly coverage#3851
Open
jorenham wants to merge 1 commit into
Open
Dedupe the --module override rewriting in pyrefly coverage#3851jorenham wants to merge 1 commit into
--module override rewriting in pyrefly coverage#3851jorenham wants to merge 1 commit into
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--moduleis used withpyrefly coverage, the symbol prefixes are rewritten from the file-derived name to the override name. This rewriting logic was duplicated incollect_module_reportsand the tests.This resolves the code duplication by moving the rewriting logic to
build_module_reportitself. This also micro-dedupes the formatting code in the two for loops of the rewriting logic itself.Test Plan
Tests still pass (refactor only; no behavior change)