Skip to content

Inline collect_dunder_all_or_empty in pyrefly coverage #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorenham wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Open

Inline collect_dunder_all_or_empty in pyrefly coverage #3849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions pyrefly/lib/commands/coverage/collect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,10 +1094,6 @@ fn collect_dunder_all(transaction: &Transaction, handle: &Handle) -> Option<Smal
.map(|it| it.cloned().collect())
}

fn collect_dunder_all_or_empty(transaction: &Transaction, handle: &Handle) -> SmallSet<Name> {
collect_dunder_all(transaction, handle).unwrap_or_default()
}

/// The `(module_prefix, __all__ FQNs)` that gate which `.py`-only symbols a stub merge keeps,
/// or `None` when the stub has no explicit `__all__` (leaving the merge unfiltered).
fn stub_merge_filter(
Expand Down Expand Up @@ -1380,7 +1376,7 @@ impl ModuleSymbols {
let module = transaction.get_module_info(handle)?;
let answers = transaction.get_answers(handle)?;
let exports = transaction.get_exports(handle);
let dunder_all = collect_dunder_all_or_empty(transaction, handle);
let dunder_all = collect_dunder_all(transaction, handle).unwrap_or_default();
let tco_classes = collect_type_check_only_classes(&bindings);
let mut functions = parse_functions(
&module,
Expand Down
Loading