Skip to content

fix new rule - ban raw-string quoted types #3761#3842

Open
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:3761
Open

fix new rule - ban raw-string quoted types #3761#3842
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:3761

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

Summary

Fixes #3761

raw quoted type expressions like r"int" now emit InvalidAnnotation, while still parsing the annotation afterward to avoid extra cascade errors.

Test Plan

add test

@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@yangdanny97 yangdanny97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i'll let @NathanTempest merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new rule - ban raw-string quoted types

3 participants