Skip to content

docs: fix unsupported-operation example (reports not-iterable instead)#3827

Open
Kartikey077 wants to merge 1 commit into
facebook:mainfrom
Kartikey077:fix/unsupported-operation-docs-example
Open

docs: fix unsupported-operation example (reports not-iterable instead)#3827
Kartikey077 wants to merge 1 commit into
facebook:mainfrom
Kartikey077:fix/unsupported-operation-docs-example

Conversation

@Kartikey077

Copy link
Copy Markdown

Summary

Fixes #3796

The unsupported-operation docs example used if "hello" in 1: which
actually reports not-iterable instead of unsupported-operation.

Replaced the example with x = 1 + "oops" which correctly triggers
unsupported-operation.

Test Plan

Verified locally using pyrefly CLI:

Old example:
if "hello" in 1: → reports not-iterable

New example:
x = 1 + "oops" → reports unsupported-operation

@meta-cla

meta-cla Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hi @Kartikey077!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Jun 15, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Kartikey077

Copy link
Copy Markdown
Author

@yangdanny97 could you take a look when you get a chance?
This is a small docs fix for issue #3796. Thank you!

@yangdanny97 yangdanny97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unsupported-operation example from the docs doesn't report the error

3 participants