"merge" overloads in pyrefly report #3098#3134
Open
jorenham wants to merge 1 commit intofacebook:mainfrom
Open
"merge" overloads in pyrefly report #3098#3134jorenham wants to merge 1 commit intofacebook:mainfrom
pyrefly report #3098#3134jorenham wants to merge 1 commit intofacebook:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
@rchen152 has imported this pull request. If you are a Meta employee, you can view this in D100901431. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Hey @rchen152, would you be able to take a look at this (or redirect it to someone who might be a better reviewer)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ports the typestats overload merging logic (https://github.com/jorenham/typestats/blob/5fb1144/src/typestats/analyze.py#L335-L376) to dedupe the parameters and callable signatures that make up overloads.
Fixes #3098
Test Plan
Added tests and updated existing ones