Allow overriding any successor graph (#762)#762
Open
terrelln wants to merge 5 commits into
Open
Conversation
|
@terrelln has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105367885. |
Summary: Allow the fuzzer to find the bug in D104838040 with short inputs. I haven't gotten the fuzzer to reproduce it yet, but in theory it should be able to. Reviewed By: kevinjzhang Differential Revision: D104843371
Summary: The LZ encoder capped `matchLength()` at `UINT16_MAX` because sequence match lengths are stored as `uint16_t`. If the match had been walked backward at least `UINT16_MAX` bytes, then the match finding process would resume at a position which had already been inserted into the hash table. This would result in match with `distance <= 0` and corruption would ensue. Reviewed By: Cyan4973 Differential Revision: D104838040
Summary: Add negative compression level support to directly content with Zstd negative levels. Differential Revision: D105332025
Summary: Pull Request resolved: facebook#761 Differential Revision: D104873678
Summary: LZ must be a dynamic graph because it invokes a multi-input node (ZL_NODE_MUX_LENGTHS). But we need to allow overriding the successors in a serialized graph for training and configurability. So do the same thing that FieldLZ does, which sets the index of the `customGraph` as a local int param. When the local int param is set, set the corresponding successor to that graph. NOTE: A stacked diff will be exposing all newly added parameters to the C++ API. Differential Revision: D105367885
meta-codesync
Bot
changed the title
terrelln
force-pushed
the
export-D105367885
branch
from
4a529d0 to
86c6a21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
LZ must be a dynamic graph because it invokes a multi-input node (ZL_NODE_MUX_LENGTHS).
But we need to allow overriding the successors in a serialized graph for training and configurability.
So do the same thing that FieldLZ does, which sets the index of the
customGraphas a local int param.When the local int param is set, set the corresponding successor to that graph.
NOTE: A stacked diff will be exposing all newly added parameters to the C++ API.
Differential Revision: D105367885