Fix Zip64 extra field offset computation in readCentralDirectoryFileHeader (#731)#731
Open
terrelln wants to merge 1 commit into
Open
Fix Zip64 extra field offset computation in readCentralDirectoryFileHeader (#731)#731terrelln wants to merge 1 commit into
terrelln wants to merge 1 commit into
Conversation
|
@terrelln has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103841972. |
meta-codesync
Bot
changed the title
terrelln
force-pushed
the
export-D103841972
branch
from
516f6c8 to
41af40a
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
May 5, 2026
…eader (facebook#731) Summary: The Zip64 extended information extra field only includes entries for CDFH fields that overflow to 0xFFFFFFFF. The old code used hardcoded offsets (16 for header offset, 0 for compressed size), which assumed all preceding fields were always present. This caused corruption errors on zip files where only some fields used Zip64. Fix by computing the offset dynamically based on which preceding CDFH fields actually overflowed. Also thread `opCtx` through the zip lexer for proper error reporting. Differential Revision: D103841972
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
May 5, 2026
…eader (facebook#731) Summary: The Zip64 extended information extra field only includes entries for CDFH fields that overflow to 0xFFFFFFFF. The old code used hardcoded offsets (16 for header offset, 0 for compressed size), which assumed all preceding fields were always present. This caused corruption errors on zip files where only some fields used Zip64. Fix by computing the offset dynamically based on which preceding CDFH fields actually overflowed. Also thread `opCtx` through the zip lexer for proper error reporting. Differential Revision: D103841972
terrelln
force-pushed
the
export-D103841972
branch
from
41af40a to
468a966
Compare
…eader (facebook#731) Summary: The Zip64 extended information extra field only includes entries for CDFH fields that overflow to 0xFFFFFFFF. The old code used hardcoded offsets (16 for header offset, 0 for compressed size), which assumed all preceding fields were always present. This caused corruption errors on zip files where only some fields used Zip64. Fix by computing the offset dynamically based on which preceding CDFH fields actually overflowed. Also thread `opCtx` through the zip lexer for proper error reporting. Differential Revision: D103841972
terrelln
force-pushed
the
export-D103841972
branch
from
468a966 to
c221398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Zip64 extended information extra field only includes entries for CDFH fields that overflow to 0xFFFFFFFF. The old code used hardcoded offsets (16 for header offset, 0 for compressed size), which assumed all preceding fields were always present. This caused corruption errors on zip files where only some fields used Zip64.
Fix by computing the offset dynamically based on which preceding CDFH fields actually overflowed. Also thread
opCtxthrough the zip lexer for proper error reporting.Differential Revision: D103841972