C++: Easy: Expose Underlying ZL_Decoder* Pointer from Wrapper#710
Open
felixhandte wants to merge 6 commits into
Open
C++: Easy: Expose Underlying ZL_Decoder* Pointer from Wrapper#710felixhandte wants to merge 6 commits into
ZL_Decoder* Pointer from Wrapper#710felixhandte wants to merge 6 commits into
Conversation
Summary: As title. Differential Revision: D101645553
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Reviewed By: terrelln Differential Revision: D101645608
Summary: This is more general and simpler than `getErrorContextString()`, which has side-effects. This diff also implements `ZL_OC_getErrorContextString()` in terms of `ZL_OC_findError()`. Reviewed By: terrelln Differential Revision: D101645669
Summary: This will be useful when shoving C++ stuff into the OpenZL core. Differential Revision: D101645708
Summary: As title. Reviewed By: terrelln Differential Revision: D101645755
Summary: As title. Reviewed By: kevinjzhang Differential Revision: D103061037
|
@felixhandte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103061037. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: As title.
Reviewed By: kevinjzhang
Differential Revision: D103061037