Add CBOR trace parser helper and smoke test for compression trace error testing (#557)#557
Open
Victor-C-Zhang wants to merge 1 commit into
Open
Add CBOR trace parser helper and smoke test for compression trace error testing (#557)#557Victor-C-Zhang wants to merge 1 commit into
Victor-C-Zhang wants to merge 1 commit into
Conversation
|
@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97033481. |
|
@Victor-C-Zhang has imported this pull request. If you are a Meta employee, you can view this in D97033481. |
…or testing (facebook#557) Summary: Add test infrastructure for E2E error propagation testing in compression tracing: - `TraceTestHelpers.hpp`: Header-only CBOR trace parser that decodes trace output from `CCtx::getLatestTrace()` into structured C++ types (`ParsedTrace`, `ParsedChunk`, `ParsedCodec`, `ParsedGraph`). Uses the a1cbor decode API with a test arena allocator. - `CompressTraceErrorTest.cpp`: Smoke test verifying the parse helper works on a real successful compression trace. - `COMPRESS_TRACE_ERROR_TEST_PLAN.md`: Plan document for implementing error propagation tests covering codec failures, graph failures, type conversion failures, segmenter failures, and deduplication logic. Differential Revision: D97033481 Pulled By: Victor-C-Zhang
meta-codesync
Bot
changed the title
Victor-C-Zhang
force-pushed
the
export-D97033481
branch
from
b1771b3 to
775fd59
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
…or testing (#557) Summary: Add test infrastructure for E2E error propagation testing in compression tracing: - `TraceTestHelpers.hpp`: Header-only CBOR trace parser that decodes trace output from `CCtx::getLatestTrace()` into structured C++ types (`ParsedTrace`, `ParsedChunk`, `ParsedCodec`, `ParsedGraph`). Uses the a1cbor decode API with a test arena allocator. - `CompressTraceErrorTest.cpp`: Smoke test verifying the parse helper works on a real successful compression trace. - `COMPRESS_TRACE_ERROR_TEST_PLAN.md`: Plan document for implementing error propagation tests covering codec failures, graph failures, type conversion failures, segmenter failures, and deduplication logic. Differential Revision: D97033481 Pulled By: Victor-C-Zhang fbshipit-source-id: ad848561696ef5e1d7b6848368709c34837debf9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add test infrastructure for E2E error propagation testing in compression tracing:
TraceTestHelpers.hpp: Header-only CBOR trace parser that decodes trace outputfrom
CCtx::getLatestTrace()into structured C++ types (ParsedTrace,ParsedChunk,ParsedCodec,ParsedGraph). Uses the a1cbor decode API with atest arena allocator.
CompressTraceErrorTest.cpp: Smoke test verifying the parse helper works on areal successful compression trace.
COMPRESS_TRACE_ERROR_TEST_PLAN.md: Plan document for implementing errorpropagation tests covering codec failures, graph failures, type conversion
failures, segmenter failures, and deduplication logic.
Differential Revision: D97033481
Pulled By: Victor-C-Zhang