Skip to content

fbcode_builder: force snappy to build with RTTI #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afrind wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fbcode_builder: force snappy to build with RTTI #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions build/fbcode_builder/manifests/snappy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ subdir = snappy-27ab5f7f518430a021239bc26a5b2fd64affbc7b
[cmake.defines]
SNAPPY_BUILD_TESTS = OFF
SNAPPY_BUILD_BENCHMARKS = OFF
# folly's Compression.cpp dynamic_casts snappy::Source/Sink and needs their
# typeinfo. Snappy hardcodes -fno-rtti in CMAKE_CXX_FLAGS; override via the
# per-config flags variable, which is appended after (last -f wins in gcc).
CMAKE_CXX_FLAGS_RELWITHDEBINFO = -O2 -g -DNDEBUG -frtti
CMAKE_CXX_FLAGS_RELEASE = -O3 -DNDEBUG -frtti
CMAKE_CXX_FLAGS_DEBUG = -g -frtti

# Avoid problems like `relocation R_X86_64_PC32 against symbol` on ELF systems
# when linking rocksdb, which builds PIC even when building a static lib
Expand Down
Loading