quic/api: introduce QuicPacketWriter interface and BufQuicBatchResult#449
Open
afrind wants to merge 2 commits into
Open
quic/api: introduce QuicPacketWriter interface and BufQuicBatchResult#449afrind wants to merge 2 commits into
afrind wants to merge 2 commits into
Conversation
Uses eventfd on Linux (EFD_NONBLOCK; counter semantics coalesce multiple flush() calls) and a non-blocking self-pipe on macOS. Wraps a lock-free folly::ProducerConsumerQueue for the data path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Defines the write/flush/getResult contract for pluggable packet writers. BufQuicBatchResult is moved from IoBufQuicBatch.h to break an include cycle (IoBufQuicBatch → QuicBatchWriter → StateData). Adds conn.packetWriter (unique_ptr<QuicPacketWriter>) to QuicConnectionStateBase; null on all existing paths. Conditionalizes write/flush sites on packetWriter so the inline path is unchanged when no writer is installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
|
@afrind has imported this pull request. If you are a Meta employee, you can view this in D105347776. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines the write/flush/getResult contract for pluggable packet writers.
BufQuicBatchResult is moved from IoBufQuicBatch.h to break an include cycle
(IoBufQuicBatch → QuicBatchWriter → StateData). Adds conn.packetWriter
(unique_ptr) to QuicConnectionStateBase; null on all
existing paths. Conditionalizes write/flush sites on packetWriter so the
inline path is unchanged when no writer is installed.