Skip to content

Fix selected text drag and drop precision problem#7749

Closed
asnmi wants to merge 1 commit intofacebook:mainfrom
asnmi:dragdrop
Closed

Fix selected text drag and drop precision problem#7749
asnmi wants to merge 1 commit intofacebook:mainfrom
asnmi:dragdrop

Conversation

@asnmi
Copy link
Copy Markdown

@asnmi asnmi commented Aug 10, 2025 •
edited
Loading

Description

Fix selected text drag and drop precision problem

##before

before.mp4

##after

after.mp4

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2025 10:08am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2025 10:08am

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Aug 10, 2025

Hi @asnmi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@asnmi asnmi changed the title Stabilize selected text drag and drop functionality Fix selected text drag and drop precision problem Aug 10, 2025
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2025
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Aug 10, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@etrepum
Copy link
Copy Markdown
Collaborator

etrepum commented Aug 10, 2025

While there certainly are edge cases in the existing implementation I don't think this fix is correct

pr-7749-text-dnd.mov

@medihack medihack mentioned this pull request Nov 28, 2025
Open
@etrepum etrepum added the stale-pr PRs that are closed due to staleness. Please reopen the PR if there are new updates label Feb 13, 2026
@etrepum etrepum closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@lilshady lilshady Awaiting requested review from lilshady

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale-pr PRs that are closed due to staleness. Please reopen the PR if there are new updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asnmi @etrepum