[lexical-code][lexical-playground] Chore: Added type exports for serialized nodes #7732
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbraginsky
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
meta-cla
bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
etrepum
reviewed
Aug 3, 2025
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
I don't think there's all that much use for this in general, unless you want it to show up in the API documentation. There are other ways to get to that type such as using LexicalExportJSON
| import {$createCodeNode} from './CodeNode'; | ||
|
|
||
| type SerializedCodeHighlightNode = Spread< | ||
| export type SerializedCodeHighlightNode = Spread< |
Collaborator
There was a problem hiding this comment.
This isn't sufficient to use the type because it's not exported from the package's entrypoint (index.ts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have noticed that all serialized nodes have their types exported from their respective packages with the exception of SerializedCodeHighlightNode and SerializedCollapsibleContainerNode.