Add parser support for --lines, --offset, --length#627
Open
ZacSweers wants to merge 17 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
hick209
requested changes
Jun 15, 2026
hick209
left a comment
hick209
left a comment
Contributor
There was a problem hiding this comment.
Just haven't finished core/src/main/java/com/facebook/ktfmt/format/Formatter.kt, but here's the start.
I'll resume tomorrow
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this in D109301187. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #218 and includes IDE support as well.
Note that I opted to match GJF's current behavior and allow statement-level boundaries (the issue described function-level granularity only, but that's not what I see GJF do).