Skip to content

Conversation

@benoit-nexthop
Copy link
Contributor

@benoit-nexthop benoit-nexthop commented Dec 18, 2025

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

This can handle only one session per user, the current live config is
copied into ~/.fboss2/agent.conf and when committing an atomic symlink
update is performed on /etc/coop/agent.conf, which is the only config
file supported by this basic prototype.

Note: this change is part of a series, the previous one is #755, the next one is #757.

Test Plan

Unit tests.

@meta-cla meta-cla bot added the CLA Signed label Dec 18, 2025
@benoit-nexthop benoit-nexthop marked this pull request as ready for review December 18, 2025 00:36
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part04 branch 2 times, most recently from 4e3a7a0 to f8a4f7b Compare December 23, 2025 21:38
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part04 branch 5 times, most recently from 6337d9c to 76c74c2 Compare December 30, 2025 15:49
meta-codesync bot pushed a commit that referenced this pull request Dec 31, 2025
Summary:
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

This is a small helper class used to lookup ports and interfaces in a consistent fashion in CLI commands.

Note: this change is part of a series, the previous one is #754, the next one is #756.

Pull Request resolved: #755

Test Plan: Unit tests.

Reviewed By: KevinYakar

Differential Revision: D89903145

Pulled By: joseph5wu

fbshipit-source-id: e36f8198ed19bb4141285b56da93632f8d660a06
This can handle only one session per user, the current live config is
copied into `~/.fboss2/agent.conf` and when committing an atomic symlink
update is performed on /etc/coop/agent.conf, which is the only config
file supported by this basic prototype.
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part04 branch from 76c74c2 to 7765776 Compare January 2, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants