Skip to content

[Nexthop][fboss2-dev] Add a utility class to help map ports to interfaces. #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benoit-nexthop wants to merge 1 commit into from
Closed

[Nexthop][fboss2-dev] Add a utility class to help map ports to interfaces. #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmake/CliFboss2.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ add_library(fboss2_lib
fboss/cli/fboss2/utils/CLIParserUtils.cpp
fboss/cli/fboss2/utils/CmdClientUtils.cpp
fboss/cli/fboss2/utils/CmdUtilsCommon.cpp
fboss/cli/fboss2/utils/PortMap.cpp
fboss/cli/fboss2/utils/Table.cpp
fboss/cli/fboss2/utils/HostInfo.h
fboss/cli/fboss2/utils/FilterOp.h
Expand Down
1 change: 1 addition & 0 deletions cmake/CliFboss2Test.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ add_executable(fboss2_cmd_test
# fboss/cli/fboss2/test/CmdShowTransceiverTest.cpp - excluded (depends on configerator bgp namespace)
fboss/cli/fboss2/test/CmdStartPcapTest.cpp
fboss/cli/fboss2/test/CmdStopPcapTest.cpp
fboss/cli/fboss2/test/PortMapTest.cpp
)

target_link_libraries(fboss2_cmd_test
Expand Down
8 changes: 8 additions & 0 deletions fboss/cli/fboss2/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ cpp_library(
"utils/CmdClientUtils.cpp",
"utils/CmdUtils.cpp",
"utils/NetwhoamiUtils.cpp",
"utils/PortMap.cpp",
"utils/PrbsUtils.cpp",
"utils/TeFlowUtils.cpp",
"utils/clients/BmcClient.cpp",
Expand Down Expand Up @@ -774,8 +775,15 @@ cpp_library(
exported_deps = [
":cmd-handler",
":fboss2-lib",
"//fboss/agent:agent_config-cpp2-types",
"//fboss/agent:agent_dir_util",
"//fboss/agent:fboss-types",
"//fboss/agent/if:ctrl-cpp2-types",
"//folly:conv",
],
exported_external_deps = [
"glog",
],
)

cpp_binary(
Expand Down
11 changes: 11 additions & 0 deletions fboss/cli/fboss2/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,15 @@ cpp_unittest(
"CmdShowTransceiverTest.cpp",
"CmdStartPcapTest.cpp",
"CmdStopPcapTest.cpp",
"PortMapTest.cpp",
],
# Config files for PortMapTest parameterized tests
resources = [
"//fboss/oss/link_test_configs:link_test_configs",
],
# Required for parameterized tests (TEST_P) - static listing doesn't support them
# See: https://fburl.com/parameterized-test-not-supported
supports_static_listing = False,
deps = [
"fbsource//third-party/googletest:gmock",
":cmd_test_utils",
Expand Down Expand Up @@ -121,9 +129,12 @@ cpp_unittest(
"//fboss/cli/fboss2/commands/show/route:model-cpp2-types",
"//fboss/cli/fboss2/commands/show/teflow:model-cpp2-types",
"//fboss/cli/fboss2/commands/show/transceiver:model-cpp2-types",
"//folly:file_util",
"//folly:network_address",
"//folly/json:dynamic",
"//folly/testing:test_util",
"//neteng/fboss/bgp/if:bgp_thrift-cpp2-services",
"//thrift/lib/cpp2/protocol:protocol",
"//thrift/lib/cpp2/reflection:testing",
],
external_deps = [("boost", None, "boost_algorithm")],
Expand Down
Loading
Loading