Admin Enable MPLS on RIFs if it is supported #742
+31
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
MPLS can be enabled on router interface using the SAI attribute SAI_ROUTER_INTERFACE_ATTR_ADMIN_MPLS_STATE. As per the SAI spec, the default for SAI_ROUTER_INTERFACE_ATTR_ADMIN_MPLS_STATE is false and needs to be enabled by the NOS. This is a fix to enable SAI_ROUTER_INTERFACE_ATTR_ADMIN_MPLS_STATE on L3 AC ports and SVIs.
Test Plan
Executed all the MPLS FBOSS test cases and verified they are passing.
HwMPLSTest/0.ExpiringTTL
HwMPLSTest/0.Php
HwMPLSTest/0.Pop
HwMPLSTest/0.Swap
HwMPLSTest/1.ExpiringTTL
HwMPLSTest/1.Php
HwMPLSTest/1.Pop
HwMPLSTest/1.Swap
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X2WideTrunksV4MplsPhpFrontPanelTraffic
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X2WideTrunksV4MplsSwapFrontPanelTraffic
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X2WideTrunksV6MplsPhpFrontPanelTraffic
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X2WideTrunksV6MplsSwapFrontPanelTraffic
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X3WideTrunksV4MplsSwapFrontPanelTraffic
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X3WideTrunksV6MplsPhpFrontPanelTraffic
AgentTrunkLoadBalancerTest.ECMPFullTrunkHalf4X3WideTrunksV6MplsSwapFrontPanelTraffic
HwTrunkLoadBalancerTest.ECMPHalfTrunkFull4X2WideTrunksV4MplsPhpFrontPanelTraffic
HwTrunkLoadBalancerTest.ECMPHalfTrunkFull4X2WideTrunksV4MplsSwapFrontPanelTraffic
HwTrunkLoadBalancerTest.ECMPHalfTrunkFull4X2WideTrunksV6MplsSwapFrontPanelTraffic
HwTrunkLoadBalancerTest.ECMPHalfTrunkFull4X3WideTrunksV4MplsPhpFrontPanelTraffic
HwTrunkLoadBalancerTest.ECMPHalfTrunkFull4X3WideTrunksV4MplsSwapFrontPanelTraffic
HwTrunkLoadBalancerTest.ECMPHalfTrunkFull4X3WideTrunksV6MplsPhpFrontPanelTraffic