[Nexthop] fboss2 CLI config prototype #668
+4,698
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Copyright (c) 2004-present, Facebook, Inc. | ||
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| */ | ||
|
|
||
| #include "fboss/cli/fboss2/CmdHandler.cpp" | ||
|
|
||
| #include "fboss/cli/fboss2/commands/config/CmdConfigAppliedInfo.h" | ||
| #include "fboss/cli/fboss2/commands/config/CmdConfigReload.h" | ||
| #include "fboss/cli/fboss2/commands/config/history/CmdConfigHistory.h" | ||
| #include "fboss/cli/fboss2/commands/config/interface/CmdConfigInterface.h" | ||
| #include "fboss/cli/fboss2/commands/config/interface/CmdConfigInterfaceDescription.h" | ||
| #include "fboss/cli/fboss2/commands/config/interface/CmdConfigInterfaceMtu.h" | ||
| #include "fboss/cli/fboss2/commands/config/rollback/CmdConfigRollback.h" | ||
| #include "fboss/cli/fboss2/commands/config/session/CmdConfigSessionCommit.h" | ||
| #include "fboss/cli/fboss2/commands/config/session/CmdConfigSessionDiff.h" | ||
|
|
||
| namespace facebook::fboss { | ||
|
|
||
| template void | ||
| CmdHandler<CmdConfigAppliedInfo, CmdConfigAppliedInfoTraits>::run(); | ||
| template void CmdHandler<CmdConfigReload, CmdConfigReloadTraits>::run(); | ||
| template void CmdHandler<CmdConfigInterface, CmdConfigInterfaceTraits>::run(); | ||
| template void CmdHandler< | ||
| CmdConfigInterfaceDescription, | ||
| CmdConfigInterfaceDescriptionTraits>::run(); | ||
| template void | ||
| CmdHandler<CmdConfigInterfaceMtu, CmdConfigInterfaceMtuTraits>::run(); | ||
| template void CmdHandler<CmdConfigHistory, CmdConfigHistoryTraits>::run(); | ||
| template void CmdHandler<CmdConfigRollback, CmdConfigRollbackTraits>::run(); | ||
| template void | ||
| CmdHandler<CmdConfigSessionCommit, CmdConfigSessionCommitTraits>::run(); | ||
| template void | ||
| CmdHandler<CmdConfigSessionDiff, CmdConfigSessionDiffTraits>::run(); | ||
|
|
||
| } // namespace facebook::fboss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Copyright (c) 2004-present, Facebook, Inc. | ||
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| */ | ||
|
|
||
| #include "fboss/cli/fboss2/CmdList.h" | ||
|
|
||
| #include "fboss/cli/fboss2/CmdHandler.h" | ||
| #include "fboss/cli/fboss2/commands/config/CmdConfigAppliedInfo.h" | ||
| #include "fboss/cli/fboss2/commands/config/CmdConfigReload.h" | ||
| #include "fboss/cli/fboss2/commands/config/history/CmdConfigHistory.h" | ||
| #include "fboss/cli/fboss2/commands/config/interface/CmdConfigInterface.h" | ||
| #include "fboss/cli/fboss2/commands/config/interface/CmdConfigInterfaceDescription.h" | ||
| #include "fboss/cli/fboss2/commands/config/interface/CmdConfigInterfaceMtu.h" | ||
| #include "fboss/cli/fboss2/commands/config/rollback/CmdConfigRollback.h" | ||
| #include "fboss/cli/fboss2/commands/config/session/CmdConfigSessionCommit.h" | ||
| #include "fboss/cli/fboss2/commands/config/session/CmdConfigSessionDiff.h" | ||
|
|
||
| namespace facebook::fboss { | ||
|
|
||
| const CommandTree& kConfigCommandTree() { | ||
|
Contributor
There was a problem hiding this comment. I can see this function will become massive once we keep adding more and more sub-commands.
Contributor
Author
There was a problem hiding this comment. I would suggest refactoring this in a separate change. We already have another change internally that is going to avoid mixing everything together like that. |
||
| static CommandTree root = { | ||
| {"config", | ||
| "applied-info", | ||
| "Show config applied information", | ||
| commandHandler<CmdConfigAppliedInfo>, | ||
| argTypeHandler<CmdConfigAppliedInfoTraits>}, | ||
|
|
||
| {"config", | ||
| "history", | ||
| "Show history of committed config revisions", | ||
| commandHandler<CmdConfigHistory>, | ||
| argTypeHandler<CmdConfigHistoryTraits>}, | ||
|
|
||
| { | ||
| "config", | ||
| "interface", | ||
| "Configure interface settings", | ||
| commandHandler<CmdConfigInterface>, | ||
| argTypeHandler<CmdConfigInterfaceTraits>, | ||
| {{ | ||
| "description", | ||
| "Set interface description", | ||
| commandHandler<CmdConfigInterfaceDescription>, | ||
| argTypeHandler<CmdConfigInterfaceDescriptionTraits>, | ||
| }, | ||
| { | ||
| "mtu", | ||
| "Set interface MTU", | ||
| commandHandler<CmdConfigInterfaceMtu>, | ||
| argTypeHandler<CmdConfigInterfaceMtuTraits>, | ||
| }}, | ||
| }, | ||
|
|
||
| { | ||
| "config", | ||
| "session", | ||
| "Manage config session", | ||
| {{ | ||
| "commit", | ||
| "Commit the current config session", | ||
| commandHandler<CmdConfigSessionCommit>, | ||
| argTypeHandler<CmdConfigSessionCommitTraits>, | ||
| }, | ||
| { | ||
| "diff", | ||
| "Show diff between configs (session vs live, session vs revision, or revision vs revision)", | ||
| commandHandler<CmdConfigSessionDiff>, | ||
| argTypeHandler<CmdConfigSessionDiffTraits>, | ||
| }}, | ||
| }, | ||
|
|
||
| {"config", | ||
| "reload", | ||
| "Reload agent configuration", | ||
| commandHandler<CmdConfigReload>, | ||
| argTypeHandler<CmdConfigReloadTraits>}, | ||
|
|
||
| {"config", | ||
| "rollback", | ||
| "Rollback to a previous config revision", | ||
| commandHandler<CmdConfigRollback>, | ||
| argTypeHandler<CmdConfigRollbackTraits>}, | ||
| }; | ||
| sort(root.begin(), root.end()); | ||
| return root; | ||
| } | ||
|
|
||
| } // namespace facebook::fboss | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't recommend vendors to touch the BUCK file as they won't be able to verify the changes using buck command.
That's why once we finish landing the PRs, we will adjust the buck file in another diff or the same diff if our on-diff signal complains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to save you time 😁