Skip to content

fix: do not use ideal image plugin in dev env #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 2 commits into from
Sep 23, 2021
Merged

fix: do not use ideal image plugin in dev env #5540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8dcde5
fix: do not use ideal image plugin in dev env
lex111 Sep 8, 2021
63fad93
Back to JS
lex111 Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/docusaurus-plugin-ideal-image/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ export default function (
_context: LoadContext,
options: PluginOptions,
): Plugin<void> {
const isProd = process.env.NODE_ENV === 'production';

return {
name: 'docusaurus-plugin-ideal-image',

Expand All @@ -24,6 +22,10 @@ export default function (
},

configureWebpack(_config: Configuration, isServer: boolean) {
if (process.env.NODE_ENV !== 'production') {
return {};
}

return {
mergeStrategy: {
'module.rules': 'prepend',
Expand All @@ -38,7 +40,6 @@ export default function (
loader: require.resolve('@docusaurus/responsive-loader'),
options: {
emitFile: !isServer, // don't emit for server-side rendering
disable: !isProd,
// eslint-disable-next-line global-require
adapter: require('@docusaurus/responsive-loader/sharp'),
name: 'assets/ideal-img/[name].[hash:hex:7].[width].[ext]',
Expand Down
7 changes: 7 additions & 0 deletions packages/docusaurus-plugin-ideal-image/src/theme/IdealImage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,18 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

import React from 'react';
import IdealImage from '@endiliey/react-ideal-image';

function Image(props) {
const {alt, className, img} = props;

// In dev env just use regular img with original file
if (img.default) {
return <img src={img.default} className={className} alt={alt} {...props} />;
}

return (
<IdealImage
{...props}
Expand Down