You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArgosAdd this label to run UI visual regression tests. See argos.yml GH action.CLA SignedSigned Facebook CLApr: bug fixThis PR fixes a bug in a past release.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slorber
added
the
Argos
Motivation
Upgrade our website to v4.5, to check compatibility.
Issues found
Missing autocomplete core types
One issue was found due to the removal of
@algolia/autocomplete-core, leading to some types not being available anymore in node modules.This is unlikely to affect anyone, apart from a few users who swizzled the SearchBar with TS.
But it's blocking the Algolia package compilation. I added an explicit dependency on it, until they fix it: algolia/docsearch#2850
Note that we have an explicit import of one of those types in SearchBar (but could probably find a way to remove/infer it:
import type {AutocompleteState} from '@algolia/autocomplete-core';Missing AI SDK types
algolia/docsearch#2850 (comment)
Test Plan
CI
Test links
https://deploy-preview-11683--docusaurus-2.netlify.app/