tests: e2e: validate sets and empty sets survive daemon restarts#424
Merged
qdeslandes merged 1 commit intofacebook:mainfrom Feb 18, 2026
Merged
tests: e2e: validate sets and empty sets survive daemon restarts#424qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes merged 1 commit intofacebook:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds end-to-end coverage to ensure bpfilter daemon restarts correctly restore chains that include both populated and empty named sets, and that filtering behavior continues to work after restore.
Changes:
- Extend
restore_attachedto create sets on an attached chain, restart the daemon, and validate set contents + filtering post-restore. - Extend
restore_non_attachedto create sets on a non-attached chain, restart the daemon, validate set contents, then attach and validate filtering. - Add output-based assertions (
bfcli chain get+grep) to confirm expected set entries are present after restart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e/daemon/restore_non_attached.sh | Adds a non-attached chain restore scenario exercising populated + empty named sets and post-restore attach/filtering. |
| tests/e2e/daemon/restore_attached.sh | Adds an attached chain restore scenario exercising populated + empty named sets and post-restore filtering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add set restore scenarios to restore_attached and restore_non_attached tests. Each creates a chain with both a populated set and an empty set, restarts the daemon, and verifies that set elements are preserved and filtering works after restore.
qdeslandes
force-pushed
the
add_set_restore_tests
branch
from
5729193 to
967fb4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add set restore scenarios to restore_attached and restore_non_attached tests. Each creates a chain with both a populated set and an empty set, restarts the daemon, and verifies that set elements are preserved and filtering works after restore.