Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies consistent code formatting across CLI and library files to improve readability and adhere to line length conventions.
Changes:
- Reformatted long function calls and error messages to wrap at reasonable line lengths
- Aligned function parameters consistently when split across multiple lines
- Improved macro formatting with proper alignment
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libbpfilter/set.c | Wrapped long bf_err_r call and bf_list_add_tail call to multiple lines |
| src/libbpfilter/matcher.c | Wrapped long bf_err_r call with format string across multiple lines |
| src/libbpfilter/include/bpfilter/chain.h | Split function declaration bf_chain_get_set_by_name parameters across lines |
| src/libbpfilter/cli.c | Wrapped bf_request_new_from_pack and bf_err_r calls across multiple lines |
| src/libbpfilter/chain.c | Split function definition bf_chain_get_set_by_name parameters across lines to match header |
| src/bfcli/opts.h | Reformatted bfc_opts_default() macro with improved alignment |
| src/bfcli/opts.c | Realigned function parameters for _bfc_opts_set_add_cb and _bfc_opts_set_remove_cb, wrapped doc string |
| src/bfcli/chain.c | Wrapped bf_set_new and bf_err_r calls across multiple lines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.