Skip to content

cli,lib: fix style#423

Merged
qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes:fixstyle
Feb 18, 2026
Merged

cli,lib: fix style#423
qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes:fixstyle

Conversation

@qdeslandes
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 07:57
@meta-cla meta-cla bot added the cla signed label Feb 18, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies consistent code formatting across CLI and library files to improve readability and adhere to line length conventions.

Changes:

  • Reformatted long function calls and error messages to wrap at reasonable line lengths
  • Aligned function parameters consistently when split across multiple lines
  • Improved macro formatting with proper alignment

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/libbpfilter/set.c Wrapped long bf_err_r call and bf_list_add_tail call to multiple lines
src/libbpfilter/matcher.c Wrapped long bf_err_r call with format string across multiple lines
src/libbpfilter/include/bpfilter/chain.h Split function declaration bf_chain_get_set_by_name parameters across lines
src/libbpfilter/cli.c Wrapped bf_request_new_from_pack and bf_err_r calls across multiple lines
src/libbpfilter/chain.c Split function definition bf_chain_get_set_by_name parameters across lines to match header
src/bfcli/opts.h Reformatted bfc_opts_default() macro with improved alignment
src/bfcli/opts.c Realigned function parameters for _bfc_opts_set_add_cb and _bfc_opts_set_remove_cb, wrapped doc string
src/bfcli/chain.c Wrapped bf_set_new and bf_err_r calls across multiple lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qdeslandes qdeslandes merged commit b527b6d into facebook:main Feb 18, 2026
35 checks passed
@qdeslandes qdeslandes deleted the fixstyle branch February 18, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments