Skip to content

Add snap preview for point placement mode#1795

Open
AnalysisRelevant wants to merge 3 commits into
facebook:mainfrom
AnalysisRelevant:feature/add-point-snap-preview
Open

Add snap preview for point placement mode#1795
AnalysisRelevant wants to merge 3 commits into
facebook:mainfrom
AnalysisRelevant:feature/add-point-snap-preview

Conversation

@AnalysisRelevant
Copy link
Copy Markdown

This is my first open source contribution, so I appreciate any feedback on the implementation.

Fixes #719 — when placing a point, there was no visual preview showing where the point would land before clicking, making snapping to ways and nodes unintuitive.

Changes:

  • Added modules/core/SnapSystem.js — a utility that computes snap targets (ways, nodes, free placement) from pointer event data. Extracted as a reusable class so other modes could potentially use it.

  • Modified AddPointMode.js to show a live preview node that follows the cursor and snaps to nearby features before the user clicks. The preview is created in staging and removed via editor.revert() on click or cancel.

  • Modified DrawBehavior.js to run snap detection on move and click events, attaching the result as eventData.snapResult. The original eventData fields are left unmodified so existing behavior in DrawLineMode and other consumers is unaffected.

The preview node is marked with the drawing class so the Pixi renderer treats it as non-interactive, preventing it from intercepting hit tests on underlying ways.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 15, 2026

Hi @AnalysisRelevant!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 15, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the cla signed label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change snap target of areas from fills to outlines.

1 participant