Skip to content

fix(ci): Build system on cloud CI should be more resilient to errors …#58

Merged
shayanhabibi merged 2 commits into
fable-hub:developfrom
shayanhabibi:npm-ci-resilience
Apr 25, 2026
Merged

fix(ci): Build system on cloud CI should be more resilient to errors …#58
shayanhabibi merged 2 commits into
fable-hub:developfrom
shayanhabibi:npm-ci-resilience

Conversation

@shayanhabibi
Copy link
Copy Markdown
Collaborator

@shayanhabibi shayanhabibi commented Apr 23, 2026

I've noticed there's been weeks of the generator failing and not raising tickets because it fails during setup.

The error is pretty benign, I'm no expert on npm so I've just added a guard which runs a normal install if the error description asks for it when running a npm ci.

…regarding setting up the environment for tests
@shayanhabibi shayanhabibi requested a review from Freymaurer April 23, 2026 01:59
Copy link
Copy Markdown
Contributor

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayanhabibi i think this is actually a valid error. It more or less means, that the packagage.json was updated or changed without updating the package-lock.json file and pushing it to version control.

As we actually run npm updates in ci in this repo (from my understanding) we would want to have the correct package-lock.json in version control that was used for passing tests

@shayanhabibi
Copy link
Copy Markdown
Collaborator Author

Ahh, I understand it's purpose now, so we should be updating the lock file in reality

@shayanhabibi
Copy link
Copy Markdown
Collaborator Author

In recognition of #60 not being fixed by burning the package-lock.json in the root, and the fact that node/js package management, and version control OUTSIDE of electron is not within the purview or concern of the binding project I'm going to merge this for the moment.

We can revert it during the week once the release is out.

@shayanhabibi shayanhabibi merged commit 3abad78 into fable-hub:develop Apr 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants