fix(ci): Build system on cloud CI should be more resilient to errors …#58
Conversation
…regarding setting up the environment for tests
Freymaurer
left a comment
There was a problem hiding this comment.
@shayanhabibi i think this is actually a valid error. It more or less means, that the packagage.json was updated or changed without updating the package-lock.json file and pushing it to version control.
As we actually run npm updates in ci in this repo (from my understanding) we would want to have the correct package-lock.json in version control that was used for passing tests
|
Ahh, I understand it's purpose now, so we should be updating the lock file in reality |
|
In recognition of #60 not being fixed by burning the package-lock.json in the root, and the fact that node/js package management, and version control OUTSIDE of electron is not within the purview or concern of the binding project I'm going to merge this for the moment. We can revert it during the week once the release is out. |
I've noticed there's been weeks of the generator failing and not raising tickets because it fails during setup.
The error is pretty benign, I'm no expert on npm so I've just added a guard which runs a normal install if the error description asks for it when running a
npm ci.