refactor!: add RequireQualifiedAccess to Erlang module#51
Merged
Conversation
Extract shared opaque types (Pid, Atom, Ref, TimerRef) to a new Types.fs in the Fable.Beam namespace so they remain accessible via open Fable.Beam. Mark the Erlang module with [<RequireQualifiedAccess>] to prevent name collisions with other libraries (e.g. Fable.Actor) that define spawn, self, send etc. BREAKING CHANGE: Erlang BIF functions now require Erlang. prefix (e.g. Erlang.spawn, Erlang.self). Types are unaffected — open Fable.Beam still brings Pid, Atom, Ref, TimerRef into scope. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pid,Atom,Ref,TimerRef) toTypes.fsin theFable.Beamnamespace[<RequireQualifiedAccess>]to theErlangmodule to prevent name collisions (e.g.spawn,self,send) with other libraries like Fable.ActorErlang.prefix for BIF callsBREAKING CHANGE: Erlang BIF functions now require
Erlang.prefix (e.g.Erlang.spawn,Erlang.self). Types are unaffected —open Fable.Beamstill bringsPid,Atom,Ref,TimerRefinto scope.Test plan
just test-dotnetpasses (0 errors)just testfull BEAM pipeline🤖 Generated with Claude Code