feat: add Logger handler config, simplify filter, and add phash2 binding#49
Merged
feat: add Logger handler config, simplify filter, and add phash2 binding#49
Conversation
…gger
Add update_handler_config/3 binding for changing handler settings like
formatter templates. Simplify add_primary_filter's filter parameter to
obj since Erlang logger filters are {fun/2, term()} tuples typically
constructed via [<Emit>].
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dbrattli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_handler_configbinding forlogger:update_handler_config/3— used to change handler settings like formatter templatesadd_primary_filterfilter parameter from(System.Func<obj, obj, obj> * obj)toobj— Erlang logger filters are{fun/2, term()}tuples typically constructed via[<Emit>]phash2binding forerlang:phash2/2— hash a term to a value in[0, Range), useful for partitioning or load balancingTest plan
Logger.update_handler_config(atom "default", atom "formatter", formatterConfig)works on BEAMLogger.add_primary_filter(atom "my_filter", filterTuple)works with Emit-constructed filtersphash2 someValue 1000000returns a consistent hash🤖 Generated with Claude Code