Add actions for msrv check and fix lints#44
Open
decryphe wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for not having done anything as per the xmldsig issue I opened more than a year ago!
Where I work the issue that needed that functionality got postponed due to other priorities, but came up again now. I thought I'd begin with a smaller housekeeping task if that's all right with you.
I added a Gitlab CI Action that checks whether a specific Rust MSRV still builds and added that to the Cargo.toml. I picked version 1.78 because it's the first version that supports Cargo.lock version 4 files.
It would be possible to downgrade to an earlier Rust version if the Cargo.lock version field is set to 3 - there's nothing in it that isn't version 3 incompatible. I tested various versions, but the oldest possible is 1.75 as the codebase uses RPIT syntax. What's your opinion on this?
In addition, I added a justfile that makes it easy to run the same commands locally that get executed by the Github Actions. I haven't found any better way yet to do this than adding a separate file and manually ensuring they don't diverge over time.