clean code #1
Open
clean code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naskapal
requested changes
Dec 21, 2020
| getEventlist() { | ||
| try { | ||
| return await this.req.get(eventListUrl, { | ||
| return this.req.get(eventListUrl, { |
Member
There was a problem hiding this comment.
the catch inside this function will be useless then?
I'm putting out catch in this function to avoid polluting the caller with handling got http error
| const { | ||
| uploadFile | ||
| } = require('./libraries/bucketManager'); | ||
| const { uploadFile } = require('./libraries/bucketManager'); |
Member
There was a problem hiding this comment.
which clean code standart are we using? why are you modifiying some into one line but leaving out the others?
|
|
||
| await login.login(email, password); | ||
| const pages = await Promise.all([login.getTicketList(), login.getEventlist(), login.getHandshakeList()]); | ||
| const pages = await Promise.all([ |
Member
There was a problem hiding this comment.
agree with this, should've spanned multiple lines
| } | ||
|
|
||
| if (handshakes.length === 0) { | ||
| } else { |
Member
There was a problem hiding this comment.
else will prone to error if we have unhandled case within the ifs, in this case, we know every possible case, so it's okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.