Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding the documentation site, I felt like we should at least upgrade the JavaScript and CSS libraries as they are 6 years old. So I upgraded Bootstrap 3 -> 4, jQuery 1 -> 3, FontAwesome 4 -> 5, and then some minor updates for tocify and jQuery UI.
I included all the fixes necessary here to transition to the upgraded frameworks. There will also be a pull request for F3com for the necessary changes to make the appearance look and feel consistent. f3-factory/F3com#30
The only major modification made in this change is I converted all
class="container"toclass="container-fluid"I also upgraded the F3 core library to3.7.2from the outdated3.6.4