Make comment_list_by_content_list fetch take all siteaccess locales into account#12
Open
emodric wants to merge 2 commits intoezsystems:masterfrom
emodric:prioritized_languages
Open
Make comment_list_by_content_list fetch take all siteaccess locales into account#12emodric wants to merge 2 commits intoezsystems:masterfrom emodric:prioritized_languages
emodric wants to merge 2 commits intoezsystems:masterfrom
emodric:prioritized_languages
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fetch doesn't display comments on objects that are created in one language, but are displayed on siteaccess where that language is not the top priority one.
The fetch should use the prioritized language list anyways, instead of reading values from ini.
I came across this issue a couple of times, so fixed it myself.