fix: on-sell commands not executing for COMMAND delivery items#67
Merged
Conversation
- Skip item count/removal check in sell() for DeliveryType.COMMAND items so the transaction succeeds even when the player has no physical items - Parse on-buy and on-sell execute-as independently in ShopPricingManager so on-sell execute-as:console is not overridden by on-buy execute-as:player - Add sellCommandsRunAsConsole field to ShopMenuLayout.Item with fallback to commandsRunAsConsole for backward compatibility - Use item.sellCommandsRunAsConsole() when dispatching sell hooks Tests: - ShopItemTypeFeatureTest: sell COMMAND delivery succeeds without physical items - ShopTransactionHookFeatureTest: sell COMMAND hooks fire; sell execute-as is independent from buy execute-as
- Add jacoco-maven-plugin 0.8.12 with prepare-agent + report bound to
test phase so coverage data is generated on every mvn test run
- Update Surefire argLine to @{argLine} for JaCoCo late-binding
- Add codecov/codecov-action@v5 upload step to unit-test and feature-test
jobs in ci.yml (flags: unit-tests / feature-tests)
- Bump version 2.5.4 → 2.5.5
- Update CHANGELOG.md with [2.5.5] section
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests: