-
-
Notifications
You must be signed in to change notification settings - Fork 45
Solve all the type issues #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is passing everywhere except Python 3.9, which hits end-of-life in October. The issue is
|
|
If you're taking votes, I'd vote for dropping 3.9 early. Folks on 3.9 can keep using the existing release. It would be tricky if you wanted to keep supporting 3.9 with other updates, but this is a simple, stable library that doesn't need frequent updates. |
|
I might make a |
|
Please make sure to add a |
|
@eyeseast Python 3.9 reached end of life two weeks ago. Any updates to get this merged? Thanks! |
|
@darkdragon-001 Probably soon. Been busy with work and haven't had a chance to come back to this. |
|
I'm going to merge this into |
Closes #116
Closes #112
Closes #121
Much more type checking, trying to be strict about things. Ultimately lots of changes that should amount to no actual change in functionality.