test(benches): add basic benchmark infrastructure #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Pull Request Test Coverage Report for Build 20247651182Details
💛 - Coveralls |
Xenira
force-pushed
the
599-add-performance-test-infrastructure
branch
8 times, most recently
from
55a35b4 to
d5bc0a9
Compare
Xenira
force-pushed
the
599-add-performance-test-infrastructure
branch
from
d5bc0a9 to
60971aa
Compare
Member
Author
|
Example upload https://bencher.php.rs/perf/ext-php-rs CI upload only works once this is merged. |
Member
Author
|
@ptondereau I think this works as an initial implementation. We should extend this further especially before tackling any performance issues. |
ptondereau
approved these changes
Dec 18, 2025
Member
ptondereau
left a comment
ptondereau
left a comment
There was a problem hiding this comment.
Look great! I tested it locally and am showing some good results indeed.
Some nitpicks
| name: Run PR Benchmarks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Member
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v6 |
| name: Archive closed PR branch with Bencher | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Member
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v6 |
| name: Run PR Benchmarks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Member
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v6 |
| name: benchmark_results.txt | ||
| path: ./benchmark_results.txt | ||
| - name: Upload Pull Request Event | ||
| uses: actions/upload-artifact@v4 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@v4 | |
| uses: actions/upload-artifact@v6 |
| - name: Run Benchmarks | ||
| run: cargo bench --manifest-path ./benches/Cargo.toml > benchmark_results.txt | ||
| - name: Upload Benchmark Results | ||
| uses: actions/upload-artifact@v4 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@v4 | |
| uses: actions/upload-artifact@v6 |
| for i in 0..n { | ||
| callback | ||
| .try_call(vec![&i]) | ||
| .expect("Failed to call function"); |
Member
There was a problem hiding this comment.
Is there a more graceful way to report an error here instead of panicking for the benchmark?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #599
Description
Adds basic benchmarking infrastructure
TODO:
Checklist
Check the boxes that apply (put an
xin the brackets, like[x]). You can also check boxes after the PR is created.❤️ Thank you for your contribution!