fix: Update logo URLs in rspress.config.ts #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the logo isn't displayed on any documentation pages (docs subfolder, anything underneath https://extension.js.org/docs/), as the reference is not correctly to the root. Due to different structure, development on localhost, etc. changing it to a different path might not be the best idea. If you'd like to prevent that absolute path, hosting these two assets in this repository as well instead of crossreferencing them might be an even more resilient approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logo isn't displayed on any documentation pages (docs subfolder, anything underneath https://extension.js.org/docs/), as the reference is not correctly to the root. Due to different structure, development on localhost, etc. changing it to a different path might not be the best idea.
If you'd like to prevent that absolute path, hosting these two assets in this repository as well instead of crossreferencing them might be an even more resilient approach.