Skip to content

Update default.smilies.sql #193#194

Open
mckillo wants to merge 4 commits intoexstreme:masterfrom
mckillo:master
Open

Update default.smilies.sql #193#194
mckillo wants to merge 4 commits intoexstreme:masterfrom
mckillo:master

Conversation

@mckillo
Copy link
Copy Markdown
Contributor

@mckillo mckillo commented Oct 6, 2024

Review the PR to update this file.
Fix #_jcomments_smilies table contains all entries in the image field with a the files into smilies folder (29 png files + 1 gif file),

Fix #_jcomments_smilies table contains all entries in the image field with a the files into smilies folder (29 png files + 1 gif file),
@mckillo
Copy link
Copy Markdown
Contributor Author

mckillo commented Oct 30, 2024

In the next release Jcomments, this data needs to change from '0000-00-00 00:00:00' to NULL (see commit).

Starting with Joomla 4, only NULL date defaults are used. The use of the invalid default date '0000-00-00 00:00:00' has been deprecated in Joomla 4. In Joomla 5, with PHP 8.2, NULL must be used (avoid issues).

@exstreme
Copy link
Copy Markdown
Owner

exstreme commented Feb 3, 2025

This file only works with installation, you should add update migration for current version I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants