feat: support hiding movie thumbnails#3
Open
garretaserra wants to merge 1 commit into
Open
Conversation
Owner
|
Hey! I haven't had much time the past few weeks, but I gave this a quick glance now. I'll test it out and merge it when I can, but so far it looks excellent! |
Author
|
I fully understand, take any time you need :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for hiding movie thumbnails.
As mentioned in #2 I would want to hide thumbnails on movie libraries because I used them for sports (F1) and if the podium or end of race interview gets picked for the thumbnail it spoils the race.
The solution included adding 2 new configurations:
Also hide movie thumbanails enables this new feature without using the already existing hide_thumbnails which would change behaviour for existing users.
Because movies don't have a parent/grandparent thumbnail it needs a default thumbnail to substitute the existing, this is why i created the other configuration which will allow specifying the file to use.
I didn't include a default image to the repo, but this could be added with a cool template to make it easier to use.
In the code the other significant edits where to ensure that parent/grandparent is not accessed directly as it won't exist and raise and error.