Skip to content

Appdata handling#320

Open
kp-mariappan-ramasamy wants to merge 4 commits intomainfrom
appdata-handling
Open

Appdata handling#320
kp-mariappan-ramasamy wants to merge 4 commits intomainfrom
appdata-handling

Conversation

@kp-mariappan-ramasamy
Copy link
Contributor

@kp-mariappan-ramasamy kp-mariappan-ramasamy commented Dec 15, 2025

Wolfssl team when discussing for another bug, discovered that we handle app_data only when secure_negotiation is enabled. But APP_DATA can be returned for DTLS1.3 which does not have secure renog

At first, APP_DATA was being used only by DTLS1.2 secure negotiation, but now it has been used in other versions like DTLS1.3.

Ref:
https://github.com/wolfSSL/wolfssl/pull/9539/changes

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Code coverage summary for 978cc7c:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                    34                 0   100.00%           4                 0   100.00%          22                 0   100.00%           0                 0         -
wolfssl/src/aes256.rs                    166                 8    95.18%          11                 0   100.00%         124                 4    96.77%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          75                 2    97.33%           5                 0   100.00%          66                 2    96.97%           0                 0         -
wolfssl/src/context.rs                   401               173    56.86%          41                14    65.85%         286               110    61.54%           0                 0         -
wolfssl/src/error.rs                      44                12    72.73%           5                 1    80.00%          43                10    76.74%           0                 0         -
wolfssl/src/lib.rs                        81                15    81.48%          11                 1    90.91%          72                13    81.94%           0                 0         -
wolfssl/src/rng.rs                        71                 9    87.32%           6                 0   100.00%          42                 3    92.86%           0                 0         -
wolfssl/src/ssl.rs                      1233               320    74.05%          85                25    70.59%         834               241    71.10%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                   2105               539    74.39%         168                41    75.60%        1489               383    74.28%           0                 0         -

✅ Region coverage 74% passes
✅ Line coverage 74% passes

@kp-mariappan-ramasamy kp-mariappan-ramasamy marked this pull request as ready for review February 24, 2026 05:45
@kp-mariappan-ramasamy kp-mariappan-ramasamy requested a review from a team as a code owner February 24, 2026 05:45
…_READY handling

DTLS 1.3 does NOT support secure renegotiation, but APP_DATA_READY
CAN still be returned in DTLS 1.3.
The check would have prevented proper handling of APP_DATA_READY in DTLS 1.3

Note: Making DTLS 1.3 to return APP_DATA_READY seems rare during handshake
and it is difficult to trigger reliably in unit tests
I missed updating the version when I merged this PR
#225
@github-actions
Copy link

🚀 Release Plan

Crate Previous version New version Release? Comment
wolfssl 4.0.0 4.1.0 ⛔ Blocked dependency on pending wolfssl-sys
wolfssl-sys 3.0.0 3.1.0 ✅ Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants