security: use OS RNG for session ID generation#347
Open
hongkongkiwi wants to merge 1 commit intoexpressvpn:mainfrom
Open
security: use OS RNG for session ID generation#347hongkongkiwi wants to merge 1 commit intoexpressvpn:mainfrom
hongkongkiwi wants to merge 1 commit intoexpressvpn:mainfrom
Conversation
Replace the internal RNG for session ID generation with the operating system cryptographically secure random number generator (OsRng). Session IDs are used for authentication and session management, making their unpredictability critical for security. The OS RNG provides better entropy guarantees than the local ChaCha20 RNG. The wire module now exports a secure_random_session_id() function that uses OsRng directly, with a check to avoid reserved values (EMPTY/REJECTED).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the internal RNG for session ID generation with the operating system cryptographically secure random number generator (OsRng).
Session IDs are used for authentication and session management, making their unpredictability critical for security. The OS RNG provides better entropy guarantees than the local ChaCha20 RNG.
The wire module now exports a secure_random_session_id() function that uses OsRng directly, with a check to avoid reserved values (EMPTY/REJECTED).