CVPN-1893 Support building on tvOS#178
Merged
kp-thomas-yau merged 4 commits intomainfrom Mar 31, 2025
Merged
Conversation
kp-thomas-yau
force-pushed
the
fs-mistrust-fork
branch
from
6208c92 to
19822cb
Compare
|
Code coverage summary for 96ba542: ✅ Region coverage 54% passes |
kp-thomas-yau
force-pushed
the
fs-mistrust-fork
branch
2 times, most recently
from
1accf3a to
982bdc5
Compare
Note: Gitlab can only make reference to commits on the main branch only, so we are using the commit hash for the merge request on main https://gitlab.torproject.org/tpo/core/arti/-/commit/0f13b7a0e19b3fae163e76c8ade6499244abf834
Use Detegr/rust-ctrlc#128 to support building or compiling on tvOS.
kp-thomas-yau
force-pushed
the
fs-mistrust-fork
branch
from
26630b2 to
96ba542
Compare
kp-thomas-yau
changed the title
kp-thomas-yau
changed the title
| clap = { version = "4.4.7", features = ["derive"] } | ||
| ctrlc = { version = "3.4.2", features = ["termination"] } | ||
| # ctrlc = { version = "3.4.2", features = ["termination"] } | ||
| ctrlc = { git = "https://github.com/Detegr/rust-ctrlc.git", rev = "refs/pull/128/head"} |
Contributor
There was a problem hiding this comment.
Why are we pinning at a specific merged branch but not master?
Contributor
Author
There was a problem hiding this comment.
I am pinning on a specific pull request Detegr/rust-ctrlc#128 's head commit, not the merged branch. Since this PR has already been merged, there's no way for someone else to modify the head commit of this PR, whereas pinning it at the master might be a security issue as someone could push a new commits to the master and do something weird/funky on it
FYI: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#choice-of-commit
kp-mariappan-ramasamy
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes building/compilation issue when we are building it in tvOS.
We are manually setting these crates to use a specific commits/PRs as we are waiting for a new official release from them:
Gitlab can only make reference to commits on the main branch only, so we are using the commit hash for the merge request on main
https://gitlab.torproject.org/tpo/core/arti/-/commit/0f13b7a0e19b3fae163e76c8ade6499244abf834
Add support for tvOS, visionOS and watchOS Detegr/rust-ctrlc#128 to support building or compiling on tvOS.
Bumped
wolfsslandtunto a new version that supports building on tvOS as well.Motivation and Context
Support tvOS
How Has This Been Tested?
By building the internal client on all 3 tvOS platforms
Types of changes
Checklist:
main